*

Offline Onix

  • *
  • Posts: 99
    • View Profile
Check out this thread on ffxiah.com (a website for auction house in Final Fantasy XI).

http://www.ffxiah.com/forum/topic/21426/pics-that-make-you-lol/1065/

Whatever script or code they're using makes the pictures automatically smaller but you can click on them to make them full size. Really nifty.

*

Offline Pete Svarrior

  • e
  • Planar Moderator
  • *****
  • Posts: 11137
  • (>^_^)> it's propaganda time (◕‿◕✿)
    • View Profile
    • The Flat Earth Society
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #1 on: May 06, 2014, 08:27:59 PM »
Easy enough. I wrote a small change to the JavaScript that currently handles image resizing. We can deploy it anytime if people think this is a good idea.
Read the FAQ before asking your question - chances are we've already addressed it.
Follow the Flat Earth Society on Twitter and Facebook!

<Parsifal> I like looking at Chinese Wikipedia with Noto installed
<Parsifal> I don't understand any of it but the symbols look nice

*

Offline Onix

  • *
  • Posts: 99
    • View Profile
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #2 on: May 06, 2014, 08:31:01 PM »
Easy enough. I wrote a small change to the JavaScript that currently handles image resizing. We can deploy it anytime if people think this is a good idea.

I'm all for it. Noticed I posted some large pictures in CN and they were just oriented all wonky and a mod resized them. Which is fine but it'd be nice to have an option to resize on click.

*

Offline Pete Svarrior

  • e
  • Planar Moderator
  • *****
  • Posts: 11137
  • (>^_^)> it's propaganda time (◕‿◕✿)
    • View Profile
    • The Flat Earth Society
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #3 on: May 06, 2014, 08:33:18 PM »
I'm all for it. Noticed I posted some large pictures in CN and they were just oriented all wonky and a mod resized them. Which is fine but it'd be nice to have an option to resize on click.
The way it's currently supposed to work is that if you post a resized image, you can click to restore it to the full size, e.g.:



While writing the changes I noticed that the CN theme doesn't do that, so we'll fix that at the very least. But I think I agree with you that setting a maximum image width is a good idea.
« Last Edit: May 06, 2014, 08:36:58 PM by pizaaplanet »
Read the FAQ before asking your question - chances are we've already addressed it.
Follow the Flat Earth Society on Twitter and Facebook!

<Parsifal> I like looking at Chinese Wikipedia with Noto installed
<Parsifal> I don't understand any of it but the symbols look nice

*

Offline Pete Svarrior

  • e
  • Planar Moderator
  • *****
  • Posts: 11137
  • (>^_^)> it's propaganda time (◕‿◕✿)
    • View Profile
    • The Flat Earth Society
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #4 on: May 06, 2014, 09:08:26 PM »
For the time being, I pushed changes to the default, tintagel_fes and Core themes for Parisifal to review and deploy. Christmas_Season_2 (aka CN) is being a bit harder to modify, but I'll have a look at it Soon(tm).
Read the FAQ before asking your question - chances are we've already addressed it.
Follow the Flat Earth Society on Twitter and Facebook!

<Parsifal> I like looking at Chinese Wikipedia with Noto installed
<Parsifal> I don't understand any of it but the symbols look nice

Re: Legit suggestion about how to handle large pictures in posts...
« Reply #5 on: May 06, 2014, 09:43:17 PM »
Rejected pull request. Please add readme.

*

Offline Pete Svarrior

  • e
  • Planar Moderator
  • *****
  • Posts: 11137
  • (>^_^)> it's propaganda time (◕‿◕✿)
    • View Profile
    • The Flat Earth Society
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #6 on: May 08, 2014, 03:25:03 AM »
Don't mind me, just posting a ginormous image without specifying the width.



(Currently not implemented in CN because the CN theme is fucking horrible)
« Last Edit: May 08, 2014, 03:29:35 AM by pizaaplanet »
Read the FAQ before asking your question - chances are we've already addressed it.
Follow the Flat Earth Society on Twitter and Facebook!

<Parsifal> I like looking at Chinese Wikipedia with Noto installed
<Parsifal> I don't understand any of it but the symbols look nice

Re: Legit suggestion about how to handle large pictures in posts...
« Reply #7 on: May 08, 2014, 08:12:17 PM »
back in the day that kind of shit would get you banned.

*

Offline Pete Svarrior

  • e
  • Planar Moderator
  • *****
  • Posts: 11137
  • (>^_^)> it's propaganda time (◕‿◕✿)
    • View Profile
    • The Flat Earth Society
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #8 on: May 08, 2014, 08:14:23 PM »
back in the day that kind of shit would get you banned.
Luckily, those grim times are nothing more but a thing of the past.
Read the FAQ before asking your question - chances are we've already addressed it.
Follow the Flat Earth Society on Twitter and Facebook!

<Parsifal> I like looking at Chinese Wikipedia with Noto installed
<Parsifal> I don't understand any of it but the symbols look nice

*

Offline markjo

  • Purgatory
  • *
  • Posts: 4411
  • Zetetic Council runner-up
    • View Profile
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #9 on: May 09, 2014, 02:07:17 AM »
Don't mind me, just posting a ginormous image without specifying the width.

http://rickpdx.files.wordpress.com/2008/03/huge-ssc2006-17a.jpg

(Currently not implemented in CN because the CN theme is fucking horrible)
Is it just me, or does the whole image load full size before it's resized?
Abandon hope all ye who press enter here.

Science is what happens when preconception meets verification.

If you can't demonstrate it, then you shouldn't believe it.

*

Offline Lord Dave

  • *
  • Posts: 5524
  • Grumpy old man.
    • View Profile
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #10 on: May 09, 2014, 02:20:17 AM »
Don't mind me, just posting a ginormous image without specifying the width.

http://rickpdx.files.wordpress.com/2008/03/huge-ssc2006-17a.jpg

(Currently not implemented in CN because the CN theme is fucking horrible)
Is it just me, or does the whole image load full size before it's resized?
It does.

*

Offline markjo

  • Purgatory
  • *
  • Posts: 4411
  • Zetetic Council runner-up
    • View Profile
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #11 on: May 09, 2014, 02:34:21 AM »
Don't mind me, just posting a ginormous image without specifying the width.

http://rickpdx.files.wordpress.com/2008/03/huge-ssc2006-17a.jpg

(Currently not implemented in CN because the CN theme is fucking horrible)
Is it just me, or does the whole image load full size before it's resized?
It does.
Should it?  I may be wrong, but it almost seems to defeat the purpose.
Abandon hope all ye who press enter here.

Science is what happens when preconception meets verification.

If you can't demonstrate it, then you shouldn't believe it.

*

Offline Pete Svarrior

  • e
  • Planar Moderator
  • *****
  • Posts: 11137
  • (>^_^)> it's propaganda time (◕‿◕✿)
    • View Profile
    • The Flat Earth Society
Re: Legit suggestion about how to handle large pictures in posts...
« Reply #12 on: May 09, 2014, 02:49:26 AM »
It does, yes. I didn't think it would be a problem (keep in mind that most pictures won't be quite as huge and will load considerably faster). This could be solved by making the images load with the width limit already in place.

A consequence of that would be that if you were to load the thread with no javascript support, you would always see the images scaled down without an easy way of scaling them back up. The way I have it set up, if you view the thread with no JS, you will see all images in their full size (i.e. no difference from how things were in the past). If people feel that having it the other way around would be better, that's a very easy fix.

EDIT: Actually, it won't be that hard to get the best of both words. I'll fix it soon.
« Last Edit: May 09, 2014, 02:52:34 AM by pizaaplanet »
Read the FAQ before asking your question - chances are we've already addressed it.
Follow the Flat Earth Society on Twitter and Facebook!

<Parsifal> I like looking at Chinese Wikipedia with Noto installed
<Parsifal> I don't understand any of it but the symbols look nice