The Flat Earth Society

The Flat Earth Society => Suggestions & Concerns => Topic started by: Baby Thork on December 11, 2018, 02:20:27 AM

Title: Smileys are busting https
Post by: Baby Thork on December 11, 2018, 02:20:27 AM
Hit reply to this post ... the site becomes insecure. The little smileys are all being pulled from 'http://forum.tfes.org/Smileys/default/smiley.gif' and not from https. It annoys me when the little padlock gives way to a raging exclamation mark. Please add the required 's' to eliminate this mixed content issue.

Thanks.
Title: Re: Smileys are busting https
Post by: Parsifal on December 11, 2018, 06:44:59 AM
So this was just SMF being ridiculous as usual and putting an absolute URL to the smileys in the database instead of just relying on the global forum URL setting (because why would you store the forum URL in one place?).

Updated to a relative URL which should fix the issue and means that if we ever change the forum URL again this won't be an issue. Let me know if you still notice problems.
Title: Re: Smileys are busting https
Post by: Baby Thork on December 11, 2018, 11:59:34 AM
I wonder how long it would have taken John Davis to fix?

Anyway, thank you very much.