The Flat Earth Society

The Flat Earth Society => Suggestions & Concerns => Topic started by: Thork on March 25, 2015, 09:52:46 PM

Title: Unsubscribe button
Post by: Thork on March 25, 2015, 09:52:46 PM
Is there any way we can modify the forum so you can 'unsubscribe' from a thread?

'Show new replies to your posts' is very helpful, but every time I go there, its filled with junk like elder scrolls that I may have posted in once, but we are 100 pages later!

Is that an easy thing to add?
Title: Re: Unsubscribe button
Post by: Blanko on March 25, 2015, 09:59:09 PM
I would like this just so I can post to say "Unsubscribed", and then unsubscribe.
Title: Re: Unsubscribe button
Post by: rooster on March 25, 2015, 10:00:32 PM
I am a big fan of this idea.
Title: Re: Unsubscribe button
Post by: Lord Dave on March 25, 2015, 10:05:03 PM
Can't you just click the "unnotify" button next to the reply button?

Or is that not the same thing?
Title: Re: Unsubscribe button
Post by: Ghost of V on March 25, 2015, 10:06:06 PM
Yes, there is a "notify via email" option that can be toggled.
Title: Re: Unsubscribe button
Post by: Thork on March 25, 2015, 10:29:45 PM
I don't want to be notified by e-mail. Get out of my thread Lord Dave. You are misunderstanding basic English again and moving the thread away from its purpose.
Title: Re: Unsubscribe button
Post by: xasop on March 25, 2015, 11:25:46 PM
This would probably be fairly easy. I'll have a look at it on the weekend.
Title: Re: Unsubscribe button
Post by: Thork on March 25, 2015, 11:33:27 PM
Would be nice. thanks. :)
Title: Re: Unsubscribe button
Post by: Lord Dave on March 26, 2015, 01:09:05 AM
I don't want to be notified by e-mail. Get out of my thread Lord Dave. You are misunderstanding basic English again and moving the thread away from its purpose.
No, I'm trying to figure out how you subscribe to a thread.  All I see is "notify" which has a handy "unnotify" button once you are notified.
Title: Re: Unsubscribe button
Post by: Thork on March 26, 2015, 01:18:27 AM
Would you consider changing your avatar for me?

(http://mindcontrol101.com/images/BRAIN_SLUG.jpg)
Title: Re: Unsubscribe button
Post by: Lord Dave on March 26, 2015, 01:29:34 AM
What, the "notify me of replies"?
Title: Re: Unsubscribe button
Post by: Blanko on March 26, 2015, 01:30:52 AM
...
Title: Re: Unsubscribe button
Post by: Lord Dave on March 26, 2015, 01:39:54 AM
Thanks guys for being so helpful.

Rather than saying "that link in small font by your avatar at the very top of the page" you decide to be asses. 

I really should have seen this coming.
Title: Re: Unsubscribe button
Post by: Benjamin Franklin on March 26, 2015, 07:13:52 AM
On a similar note, is it possible to auto-un-subscribe from a thread should a shit poster (Thork) post in the thread?
Title: Re: Unsubscribe button
Post by: Thork on March 26, 2015, 12:51:04 PM
As Parsifal is going to have a look I'll expand on what would be nice.

When you press 'show new replies to your posts' you get the list. If they just had a little 'unfollow' button next to each one on that list, you could remove it from ever appearing until you post in there again. I'm guessing you are just resetting a flag somewhere?

Many thanks

Dr David Thork
Title: Re: Unsubscribe button
Post by: Ghost of V on March 26, 2015, 10:44:14 PM
What if you delete your posts from the thread? Will it still show up?
Title: Re: Unsubscribe button
Post by: Thork on March 27, 2015, 12:32:27 AM
I've tried. You never find them all unless you wade through dozens and dozens of posts. and it ruins the flow of threads for anyone else reading later. A button is a less anti-social thing all round.
Title: Re: Unsubscribe button
Post by: xasop on March 29, 2015, 03:33:31 PM
Didn't get to this, sorry; busy weekend. I've taken a couple of days off work around Easter, so I have a 6-day weekend coming up, during which time I'll no doubt be able to slot this in.
Title: Re: Unsubscribe button
Post by: Saddam Hussein on March 29, 2015, 04:32:21 PM
What if you delete your posts from the thread? Will it still show up?

No, it won't.
Title: Re: Unsubscribe button
Post by: xasop on April 03, 2015, 10:25:41 PM
So, it turns out SMF doesn't simply have a flag for thread subscriptions. Instead, it does a search of the database for all posts you might ever have made in any thread. Every single time you load the unread replies page. Yes.

To that end, I've created a new table in the database to track opt-out unsubscriptions, and I've written code to both update that table and check it when generating unread topics. All that's left to do now is create buttons for unsubscribing, and this should be set to push out.

However, since I'm quite tired at the moment, I'll wait until tomorrow to read through the code again before pushing it, so I don't accidentally break it for everyone and then go to sleep.
Title: Re: Unsubscribe button
Post by: Thork on April 04, 2015, 03:27:12 AM
Sounds good. thank you very much
Title: Re: Unsubscribe button
Post by: xasop on April 04, 2015, 01:11:18 PM
Well, the change is just about done; pizaaplanet has graciously offered to design buttons (since I suck at graphics stuff), and once that's done we'll be able to push out the functionality.

One thing I'm not sure of is whether people should automatically get resubscribed to a thread if they post in it again after unsubscribing. Neither pizaaplanet or I uses the new replies feature, so it's up to the people who actually do use it. What do you guys want to happen?
Title: Re: Unsubscribe button
Post by: xasop on April 04, 2015, 01:38:21 PM
One thing I'm not sure of is whether people should automatically get resubscribed to a thread if they post in it again after unsubscribing. Neither pizaaplanet or I uses the new replies feature, so it's up to the people who actually do use it. What do you guys want to happen?

Deployed, without this functionality for now. Please let me know if you notice any problems with the change, or if you have any desire for said auto-resubscription to happen.

For reference, the commit that made this change is:

https://github.com/TheFlatEarthSociety/forum.tfes.org/commit/d968e71b5550994d812751e3d26ee60be31c0938
Title: Re: Unsubscribe button
Post by: Shane on April 04, 2015, 03:16:41 PM
i don't like it. the button is big and obstructive
Title: Re: Unsubscribe button
Post by: Roundy on April 04, 2015, 03:34:16 PM
It's ugly and makes my computer look bad whenever it's on it.  Thanks Thork.  >:(
Title: Re: Unsubscribe button
Post by: Shane on April 04, 2015, 03:38:51 PM
by obstructive i mean obtrusive. dumbphone
Title: Re: Unsubscribe button
Post by: Saddam Hussein on April 04, 2015, 04:10:39 PM
Yeah, having that big blue icon in New Replies is overkill.  Let's just leave the option within the thread itself, up there with "Reply," "Notify," etc.
Title: Re: Unsubscribe button
Post by: rooster on April 04, 2015, 04:39:26 PM
Yeah, having that big blue icon in New Replies is overkill.  Let's just leave the option within the thread itself, up there with "Reply," "Notify," etc.
This is more what I was imagining.
Title: Re: Unsubscribe button
Post by: xasop on April 04, 2015, 06:51:10 PM
I'll remove the New Replies button later if nobody objects. I'd just like to give others time to present alternative opinions/suggestions first.
Title: Re: Unsubscribe button
Post by: Thork on April 04, 2015, 07:04:27 PM
Yeah, having that big blue icon in New Replies is overkill.  Let's just leave the option within the thread itself, up there with "Reply," "Notify," etc.
That means you have to go into the thread.

I actually think what we have now is fine. Its just .... different. Change is good. Stop rocking back and forth and just give it a few days.
Title: Re: Unsubscribe button
Post by: Shane on April 04, 2015, 08:57:43 PM
i like the new replies button.
Title: Re: Unsubscribe button
Post by: xasop on April 04, 2015, 09:32:06 PM
Since it seems to be hated by everyone except Thork, I've removed the button from the unread replies list.

https://github.com/TheFlatEarthSociety/forum.tfes.org/commit/6ddb4e519572f23b40c4cb0d9e7a723a4c0ddb72
Title: Re: Unsubscribe button
Post by: jroa on April 07, 2015, 12:21:48 PM
I liked having the button.  Only problems I found were that the button was too big, and that it was too close to the New button.  Logging in on my phone, I could see how it would be very easy to accidentally hit the wrong button. 
Title: Re: Unsubscribe button
Post by: rooster on April 07, 2015, 12:35:07 PM
I like the way it is much better. Thanks, Parsifal!