The Flat Earth Society

The Flat Earth Society => Announcements => Topic started by: xasop on June 29, 2014, 04:37:08 AM

Title: Why we won't upgrade to SMF 2.0.8
Post by: xasop on June 29, 2014, 04:37:08 AM
SMF released a new version a couple of weeks ago. I've pushed the changes to our upstream branch on GitHub (https://github.com/theflatearthsociety/forum.tfes.org/commit/70bfa14e2a04e8004f300c6e3fdb4ea9bb5a7ff7), but after reading through them and the changelog, I've decided not to upgrade.

That diff should speak for itself, but in case it doesn't, it contains at least as many (probably accidental) reversions and errors as improvements, and there are no security fixes to worry about. Until SMF makes another release that is actually going to be beneficial to us, we're better off sticking to 2.0.7 with our own improvements.
Title: Re: Why we won't upgrade to SMF 2.0.8
Post by: fappenhosen on June 29, 2014, 10:18:49 PM
Why are you pushing code you dont want and wont use?
Title: Re: Why we won't upgrade to SMF 2.0.8
Post by: xasop on June 30, 2014, 01:04:47 AM
Quote from: fappenhosen on June 29, 2014, 10:18:49 PM
Why are you pushing code you dont want and wont use?

For two reasons: I like to keep our upstream branch up to date with upstream releases, even if it doesn't get merged into master right away; and since upstream has no public revision control, this is the only way I can easily share diffs between versions with others (such as pizaaplanet) so we can discuss what to do.
Title: Re: Why we won't upgrade to SMF 2.0.8
Post by: fappenhosen on June 30, 2014, 08:18:25 PM
Quote from: Parsifal on June 30, 2014, 01:04:47 AM
upstream has no public revision control

OK. Wow.
Title: Re: Why we won't upgrade to SMF 2.0.8
Post by: Pete Svarrior on July 01, 2014, 04:11:06 PM
Welcome to SMF :D
Title: Re: Why we won't upgrade to SMF 2.0.8
Post by: xasop on October 04, 2014, 06:06:07 PM
Most of our concerns regarding SMF 2.0.8 have been fixed in 2.0.9, which was released just a few days ago. As such, we've now upgraded to the latest version.