The Flat Earth Society

The Flat Earth Society => Suggestions & Concerns => Topic started by: Crudblud on August 22, 2017, 02:02:44 PM

Title: Nesting Tags Inside Spoiler Tags
Post by: Crudblud on August 22, 2017, 02:02:44 PM
I keep meaning to post about this, every time I write a review of something recent it's kind of a problem, mainly because I am autistic about formatting. I don't know if the way SMF works (or doesn't, as the case may be) makes this a ridiculous hassle or what, but it would be nice if spoiler tags didn't have a "nobbc" effect on nested code.

For example: This works fine, just the way you'd expect it to (https://www.youtube.com/watch?v=vSQbTb8_btw) but this is kinda gay problematic.

Is there any way this could be fixed? Thanks.
Title: Re: Nesting Tags Inside Spoiler Tags
Post by: xasop on August 22, 2017, 03:30:18 PM
This tag has been deliberately configured this way since its introduction, as for some reason parsing the BBcode inside a spoiler tag makes it not be a spoiler.

I'm going to try to track down and fix the original problem so that we can remove this limitation.
Title: Re: Nesting Tags Inside Spoiler Tags
Post by: xasop on August 22, 2017, 04:00:22 PM
Fixed. (https://github.com/TheFlatEarthSociety/forum.tfes.org/commit/53df82c4be115d77b0d1b8ff4ee5e72133087478)
Title: Re: Nesting Tags Inside Spoiler Tags
Post by: juner on August 22, 2017, 05:29:44 PM
Nice. Thanks, Parsifal.
Title: Re: Nesting Tags Inside Spoiler Tags
Post by: Crudblud on August 22, 2017, 05:42:47 PM
Beautiful. Thank you!
Title: Re: Nesting Tags Inside Spoiler Tags
Post by: Pete Svarrior on August 23, 2017, 07:44:09 AM
There's a minor issue with this - using underlines in spoilers appears to break while editing the post.

(https://puu.sh/xhjZU/04d38a8136.png)

It seems to have to do with line 515 of our main CSS file (https://github.com/TheFlatEarthSociety/forum.tfes.org/blob/master/Themes/blanko_fes/css/index.css#L515). It's far from a big issue, but the disconnect between the post preview and the actual post could cause some confusion (as it did in my case - I originally posted here to say that underlines within spoiler tags are bork)