The Flat Earth Society

The Flat Earth Society => Suggestions & Concerns => Topic started by: NotSoSkeptical on February 24, 2019, 04:31:16 PM

Title: Profile Edits Dropping Login
Post by: NotSoSkeptical on February 24, 2019, 04:31:16 PM

Everytime I edit my profile it logs me out even though I have it set to keep me logged in.  Is this normal for this version of SMF?

Title: Re: Profile Edits Dropping Login
Post by: Rushy on February 24, 2019, 05:20:34 PM

I just replicated this issue on my account as well, it appears that editing your profile does seem to log you out for some reason. I don't believe that's an intended feature.

Title: Re: Profile Edits Dropping Login
Post by: Pete Svarrior on February 24, 2019, 06:00:09 PM

This appears to be an error on my part from our recent password hashing update (https://forum.tfes.org/index.php?topic=13326.0). I misunderstood what the if statement here (https://github.com/TheFlatEarthSociety/forum.tfes.org/commit/d0bda62265b1f9bc5be9bc88f664d01876be267a) actually does, thus generating an invalid login cookie every time a user edits their profile without changing their password.

This has now been undone (https://github.com/TheFlatEarthSociety/forum.tfes.org/pull/2/commits/341890589dc74fd9ae249725bec3f5fc4d1fca02), and we're all ever-more-aware of just how fun modifying SMF is.

EDIT: Parsifal is claiming credit for the original error. I'll allow it.

Title: Re: Profile Edits Dropping Login
Post by: xasop on February 24, 2019, 06:37:30 PM

Quote from: Pete Svarrior on February 24, 2019, 06:00:09 PM

EDIT: Parsifal is claiming credit for the original error. I'll allow it.

wow rude